Subject: Issues White screen of death when posting new issue
Michael Clark
Browser: Fx 3.5.4
URL where it occured: http://github.com/petteyg/code_check/issues
(clicked on "create a new issue" link in center of page)
Posted content:
-Title: Being nitpicky -----------------------------Body>
Regarding code_convention.php:
grep -T doesn't work on my system, but the intent seems preserved
without it. Since I couldn't figure out why it was there, I removed
it, and it seemed to work as intended.
In your for loop, you need to reset $output before running exec again, or the results are concatenated. This produces much redundant output.
The Folder class is [i]very slow[/i]. Since you were already using exec, I took the liberty of replacing it with [code]exec("find $root -name '*.php'", $files);[/code]
The preg_match on line 45 fails when an if starts against the gutter - the fix is to replace the + with a *, and it works as intended in all cases (a potentially dangerous situation given the replacement function).
Some things that I think would be neat to see are:
[ulist] [li]Optional chomping of closing newline in
code_whitespace.php[/li] [li]Option for automatic replacement for a
whole app (running without asking if I'm sure) / or saying yes just
once per file.[/li] [li]A "virtual mode", where instead of actually
writing the file, it dumps a diff of the changes and moves on.[/li]
[/ulist]
Some nitpicking because I also like to code:
[ulist] [li]That for could just as well have been a foreach, and no
need to manage $i yourself that way.[/li] [li]I'd prefer the
file_put_contents() call be performed only once per
file_get_contents() - a dirty flag would serve to track if it
should be written at the end.[/li] [li]Ignoring the vendors
directory, as that code does not need to follow Cake standards
(hint, pretty easy with the find call - add "-not -wholename
'/vendors/'" after the name check)[/li] [li]despite find
using an odd order, piping the output through sort to process the
files in a more logical order[/li] [/ulist]
Comments are currently closed for this discussion. You can start a new one.
Support Staff 2 Posted by Tekkub on 05 Nov, 2009 11:47 PM
I can't reproduce this, is it happening to you consistently, or was it a one-time error?
3 Posted by Michael Clark on 06 Nov, 2009 12:34 AM
Possibly due to not being logged in, think I forgot to mention it in my
issue report. I was able to reproduce it 3 times in a row before I gave
up trying to post it. I suspect log in is the issue since the button to
the left links to the login page (which I didn't notice until I was
writing the issue report - that whole thing about users not reading
anything is kinda true :/.
> // Add your reply above here
> ==================================================
> From: Tekkub
> Subject: Issues White screen of death when posting new issue
>
> I can't reproduce this, is it happening to you consistently, or was it a one-time error?
>
> View this Discussion online: http://support.github.com/discussions/issues-issues/101-issues-white-screen-of-death-when-posting-new-issue
> --
> Reply with #ignore to stop receiving notifications for this discussion.
>
>
Support Staff 4 Posted by Tekkub on 06 Nov, 2009 12:36 AM
Ah, is it only happening if you're logged out? We've been meaning to change the forms if the user isn't logged in, since they can't post an issue while logged out.
Support Staff 5 Posted by Tekkub on 06 Nov, 2009 12:39 AM
Actually, it looks like if I'm logged out, the "Create Issue" button just links to the login page...
6 Posted by Michael Clark on 06 Nov, 2009 05:11 AM
Yeah, it's the AJAX link that gives me the form while not logged in, and then the white screen of death after,
Support Staff 7 Posted by Tekkub on 07 Nov, 2009 01:13 AM
I'm not able to reproduce this... when logged out the button is non-ajax, just a direct link to the login page. After login I'm taken to my dashboard. Granted, it should return to the issue tracker I was looking at, but that's not a breaking error.
8 Posted by Michael Clark on 09 Nov, 2009 04:10 PM
I'm having trouble understanding the button. I never looked at the button, never have clicked on it, etc. I've only ever clicked the ajax link that dynamically loads the form, followed by the submit input element which is part of the form. The button did not catch my attention when I went to submit an issue - only the link to "create a new issue" caught my eye, and is what I clicked on. I've reproduced it with a different computer and browser, and without any of the above text (just the word test in each field). I understand now that I should have been logged in to submit an issue - I think that when I don't click on the button to submit an issue, it would be nice to get something other than the white screen of death.
9 Posted by I give up on 09 Nov, 2009 04:20 PM
I'm having trouble understanding the button. I never looked at the button, never have clicked on it, etc. I've only ever clicked the ajax link that dynamically loads the form, followed by the submit input element which is part of the form. The button did not catch my attention when I went to submit an issue - only the link to "create a new issue" did. I clicked on that and I did not click on the button. The button was not what I clicked on. To be clear, I clicked on the ajax link and I did not click on the button. I have attached screenshots of me not clicking on the button, but on the ajax link which is not a button. Unsurprisingly, the button is not an ajax link, and I did not click on it.
Quoting the OP: "URL where it occured: http://github.com/petteyg/code_check/issues (clicked on "create a new issue" link in center of page)". I give up - I'll attach screenshots. If you still can't reproduce it I'll go away.
Support Staff 10 Posted by Tekkub on 09 Nov, 2009 08:18 PM
Oh, I forgot about that link there... I've been working in repo that had issues open. We probably missed that when we fixed the button. I'll open a ticket to get it fixed.